-
Notifications
You must be signed in to change notification settings - Fork 470
Apply SELECT
policies if RETURNING
has cols
#19720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Apply SELECT
policies if RETURNING
has cols
#19720
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed: |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
thanks for the review comments @spilchen , I've taken a shot at updating based on your latest feedback, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for revising.
One minor comment, but I'll leave it to you if you want to apply it: I'm wondering if you want to reverse the definition of ✓(b) and ✓(a) since the description of ✓(a) references ✓(b)?
Something like:
- ✓: Always applied.
- (a): A
USING
policy failure causes the statement to fail. Normally,USING
filters out rows silently. - (b): Like ✓(a), but only applied when the statement references row columns (
WHERE
,SET
, orRETURNING
). If the policy is violated, the statement fails.
Thank YOU for reviewing!
Yes I think that's way clearer! Have swapped |
Fixes DOC-13890